Print

[style-sheets]

Hi!

I read that the TOmniCS is basically a wrapper around TCriticalSection, I'm using it with pipelines, the code is:

Code: [Select]

// ---------------------------------------------------------------- //
procedure my_routine();
var
    AFile : TOmniValue;
begin
        if Pipeline = nil then
           Pipeline  := Parallel.Pipeline.NumTasks(10).Stage(StageProc).Run;

        AFile.CreateNamed(['FileURL', FileURL, 'FolderGUID', FolderGUID]);
        Pipeline.Input.Add(AFile);
end;
// ---------------------------------------------------------------- //
procedure StageProc(const Input, Output : IOmniBlockingCollection; const Task : IOmniTask);
begin
        Lock.Acquire;    // <-- [ Lock ] is a TOmniCS that's declared & used globally all across my app.
        try
           // Do some critical DB stuff
        finally
               Lock.Release;
        end;    // try/finally
end;
// ---------------------------------------------------------------- //

But clearly Lock doesn't happen and I'm getting exceptions because of that.

My question is: how can I change this code to make locking happen?

Thanks in advance!
Khaled.

[Primoz Gabrijelcic]

You code fragment looks fine, the problem must lie somewhere else in the original code.

[style-sheets]

Man multithreading debugging is hard 

Despite the fact that critical section wraps only 2 lines of code, admittedly I'm a bit lost (plus the exceptions do happen sporadically).

Anyway, with TThread I could set thread names in order to make it easier for debugging (in addition to log tracing), I wonder if it's possible to change tasks name here, ie.

Code: [Select]

procedure StageProc(const Input, Output : IOmniBlockingCollection; const Task : IOmniTask);
begin
        Task.Name := Value.AsArray['FileName'].AsString;
        ...
end;
Of course Task is a constant in this case, and so I'm even more blind when I try to debug & see what's wrong

[Primoz Gabrijelcic]

Just call SetThreadName from the OtlCommon unit.

[style-sheets]

Thank you Primoz!